[MIRROR] Incoming stamina damage while in stamcrit has diminishing returns applied #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns applied [MDB IGNORE] (#2987) * Incoming stamina damage while in stamcrit has diminishing returns applied * This was not even used * Update death_consequences_trauma.dm --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Mal <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jun 13, 2024
Iajret
pushed a commit
that referenced
this pull request
Jul 16, 2024
…adouts [MDB IGNORE] (#3788) Adds an assistant preview outfit for previewing assistant loadouts (#84861) The loadout PR changed it so the assistant's loadout preview used an outfit called "Assistant - Consistent" to keep it a consistent grey, only issue is that the consistent outfit does not consider the user's suit preference so it'd stay as a grey jumpsuit even if skirts were preferred, this PR adds a new assistant outfit called "Assistant - Preview" to be used for loadout previews. I opted against adding the suit check to the consistent outfit instead since as far as I can see it is meant to stay at a consistent grey suit for mob spawns, icons and unit tests and that could end up creating more issues otherwise. https://github.com/tgstation/tgstation/assets/66234359/502cd0c5-ec51-43bf-bbc2-6f5435047d2a Fixes tgstation/tgstation#83908 It fixes an issue where only assistant jumpsuits were shown on the character preview if you have assistant selected to on, regardless of your suit preferences. :cl: Hardly3D fix: Added a preview assistant outfit, allowing assistant jumpskirts to be previewed again on character preferences. /:cl: Co-authored-by: Hardly3D <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2987
Original PR: tgstation/tgstation#83445
About The Pull Request
After being put in stamcrit, future incoming stamina damage has "diminishing returns" applied*.
The formula looks like
ceil(sqrt(amount of stamina damage) / 2) - times you have taken stamina damage in stamcrit.This means eventually stamina based damage will do less than zero damage, and thus, not contribute to keeping stamcrit active.
Very, very low amounts of stamina damage (such as from chems) contribute to DR 1/20th the amount.
*Note, this is not real diminishing returns because making it real diminishing returns would be pointless, you are capped to 120 stamina damage so 99.99% of the time you take stam damage while in stam crit you're already capped. This is just faking the effect.
In its current stat this means that a stun baton will stop being able to keep someone in stamcrit after the 5th hit, and a stock disabler will stop being able to keep someone in stamcrit after the 4th hit.
Why It's Good For The Game
Mostly just an experiment. I don't imagine it will shake up much about the baton situation in its current state.
There's also no grace period after getting UP - so like you can just be stamcritted right after anyways. Maybe there should be one? Food for thought.
And yes of course you can just space out your hits, you're not clever for thinking about that
Changelog
🆑 Melbert
balance: Taking stamina damage in stamcrit has diminishing returns associated, meaning you cannot be infinitely stamcrit.
/:cl: